Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge 22 -> 23 for docs change #3352

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore: merge 22 -> 23 for docs change #3352

merged 2 commits into from
Dec 12, 2024
+13 −9

Conversation

brian-smith-tcril
Copy link
Contributor

  • docs: document where to target PRs in a table in the README

  • docs: remove redundant breaking change information

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@brian-smith-tcril
docs: document where to target PRs in a table in the README (#3344)
e58002f 
* docs: document where to target PRs in a table in the README

* docs: remove redundant breaking change information
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit 8a828cf
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/675b06e43b6b5b0008ae0f6c
😎 Deploy Preview https://deploy-preview-3352--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for paragon-openedx-v23 ready!

Name Link
🔨 Latest commit 8a828cf
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v23/deploys/675b06e48adc940008a3eb38
😎 Deploy Preview https://deploy-preview-3352--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (2bea4c9) to head (8a828cf).
Report is 414 commits behind head on release-23.x.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-23.x    #3352   +/-   ##
=============================================
  Coverage         93.48%   93.48%           
=============================================
  Files               251      252    +1     
  Lines              4648     4649    +1     
  Branches           1084     1088    +4     
=============================================
+ Hits               4345     4346    +1     
- Misses              297      300    +3     
+ Partials              6        3    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril
Copy link
Contributor Author

closing/reopening to try to re-run ci

@brian-smith-tcril brian-smith-tcril merged commit 9d08614 into release-23.x Dec 12, 2024
18 of 19 checks passed
@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 23.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-smith-tcril @openedx-semantic-release-bot @adamstankiewicz